-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libatomic1 dependency missing in build #4
Comments
@jzila May I ask for the content of your On the other hand, from your |
v8-android-buildscripts.sh, which is the one that's failing:
I'll try it out with your recommendation to make a non-root user (that can sudo). |
First off, thank you for this set of scripts, and thanks for your time in helping me out. OK I'm trying using the steps in your DockerfileFROM ubuntu:18.04
RUN apt-get update
ENV DEBIAN_FRONTEND=noninteractive
RUN ln -s /usr/share/zoneinfo/UTC /etc/localtime
RUN apt-get install -y tzdata sudo apt-utils lsb-core git python nodejs npm wget
RUN useradd -rm -d /home/ubuntu -s /bin/bash -g root -G sudo -u 1000 ubuntu
RUN echo "ubuntu ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
USER ubuntu
WORKDIR /home/ubuntu
ADD ./container/scaffolding.sh .
ADD ./container/v8-android-buildscripts.sh .
ARG V8_COMMIT=origin/master
# Clone the github.com/Kudo/v8-android-buildscripts repository at the target commit.
RUN ./v8-android-buildscripts.sh -c $V8_COMMIT
WORKDIR /home/ubuntu/v8-android-buildscripts
RUN bash -c ". scripts/export_npm_env.sh && scripts/setup.sh android"
RUN bash -c ". scripts/export_npm_env.sh && scripts/patch.sh android"
RUN bash -c ". scripts/export_npm_env.sh && scripts/build.sh android"
RUN bash -c ". scripts/export_npm_env.sh && scripts/archive.sh android"
RUN bash -c "NO_INTL=1 . scripts/export_npm_env.sh && scripts/build.sh android"
RUN bash -c "NO_INTL=1 . scripts/export_npm_env.sh && scripts/archive.sh android" Dockerfile fails at build step
|
@jzila Could you double check to sync the latest patch code here, https://github.com/Kudo/v8-android-buildscripts/blob/master/patches/v8_shared_library.patch? |
I'm synced to master on this repo (github.com/Kudo/v8-android-buildscripts), although I was trying to build V8 8.1.27. I've changed it to the latest one you've released (7.8.1), and I'm back to weird library dependency errors:
|
FWIW I also tried it matching versions (release v7.8.1 on github.com/Kudo/v8-android-buildscripts, and $V8_VERSION=7.8.1), but it had the same error. |
@jzila Well, do you mind to share all your source code of v8-android-buildscripts fork? |
Right now I'm not using a fork at all, just trying to check out your source directly. I'll attach the whole Dockerfile as-is. |
|
Happy New Year! Please let me know if there's anything else you need from me to help debug this. |
I am sorry to reply lately. |
Those dont do anything any more since I unpacked the whole script into the dockerfile. You can just remove those lines. |
@jzila I got the problem. v8 7.8.1 has some builds error, so please use 7.8.279.23 to make sure everything goes fine. |
I'll try that now and get back to you. Are any of the 8.* versions functional? |
Changing the
|
I'm testing with the env vars exported now. |
Same issue with the env vars exported. |
@jzila This Dockerfile works for me. FROM ubuntu:18.04
RUN apt-get update
ENV DEBIAN_FRONTEND=noninteractive
RUN ln -s /usr/share/zoneinfo/UTC /etc/localtime
RUN apt-get install -y tzdata sudo apt-utils lsb-core git python nodejs npm wget
RUN useradd -rm -d /home/ubuntu -s /bin/bash -g root -G sudo -u 1000 ubuntu
RUN echo "ubuntu ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
USER ubuntu
WORKDIR /home/ubuntu
# ADD ./container/scaffolding.sh .
# ADD ./container/v8-android-buildscripts.sh .
ARG V8_COMMIT=origin/master
# Clone the github.com/Kudo/v8-android-buildscripts repository at the target commit.
RUN bash -c "git clone \"https://github.com/Kudo/v8-android-buildscripts.git\" \"$HOME/v8-android-buildscripts\""
WORKDIR /home/ubuntu/v8-android-buildscripts
RUN bash -c "git fetch origin"
RUN bash -c "git checkout \"${V8_COMMIT}\""
ENV V8_VERSION=7.8.279.23
ENV VERSION=7.8.2
RUN bash -c "scripts/setup.sh -r ${V8_VERSION} android"
RUN bash -c "scripts/patch.sh android"
RUN bash -c "scripts/build.sh android"
RUN bash -c "scripts/archive.sh android"
RUN bash -c "NO_INTL=1 scripts/build.sh android"
RUN bash -c "NO_INTL=1 scripts/archive.sh android" |
Awesome, yes this worked. Thank you! |
Closing this issue since it's fixed for me. Thank you again! |
Hi,
I'm trying to build this in a stock-ish Ubuntu container, but I can't seem to figure out how to get the script to find
libatomic.so.1
. It fails near the end no matter what I do. It worked 2 months ago, but recently it no longer works.The error:
Any suggestions?
The text was updated successfully, but these errors were encountered: