Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the latter volume dirs overwrite the prior one #1214

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

vietanhtwdk
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix volumes deployment

Which issue(s) this PR fixes:

Fixes #1213

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


Copy link

github-actions bot commented Jul 10, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@vietanhtwdk
Copy link
Contributor Author

I assume that configMaps have same problem but not tested yet

@vietanhtwdk vietanhtwdk force-pushed the fix-dir branch 2 times, most recently from d70c7a0 to 34c2628 Compare July 10, 2024 04:21
@vietanhtwdk
Copy link
Contributor Author

recheck

@SparkYuan
Copy link
Member

recheck

Thanks for your feedback! Please sign the CLA by just posting a comment mentioned above and modifying your comment message and PR title accounting to the constraints in the CI.

@coveralls
Copy link

coveralls commented Jul 10, 2024

Pull Request Test Coverage Report for Build 9869423388

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 54.483%

Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/destroy.go 7 49.82%
Totals Coverage Status
Change from base Build 9867753937: -0.04%
Covered Lines: 9345
Relevant Lines: 17152

💛 - Coveralls

@vietanhtwdk
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@vietanhtwdk vietanhtwdk changed the title fix toOrderedContainers fix: the latter volume dirs overwrite the prior one Jul 10, 2024
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit a89353c into KusionStack:main Jul 10, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
@liu-hm19
Copy link
Contributor

@vietanhtwdk Thanks a lot for your contribution! This PR looks good to me, and it has been merged. Welcome to become one of the contributors of Kusion 👍 Hope you enjoy this journey : )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Dir volumes
4 participants