From 977a3903b2ac45aa882aa474d6e6783ed63aaab6 Mon Sep 17 00:00:00 2001 From: healthjyk Date: Fri, 23 Feb 2024 16:33:52 +0800 Subject: [PATCH] fix: delete the never-arriving return non-nil err --- pkg/cmd/workspace/create/cmd.go | 3 --- pkg/cmd/workspace/del/cmd.go | 3 --- pkg/cmd/workspace/list/cmd.go | 3 --- pkg/cmd/workspace/show/cmd.go | 3 --- pkg/cmd/workspace/update/cmd.go | 3 --- 5 files changed, 15 deletions(-) diff --git a/pkg/cmd/workspace/create/cmd.go b/pkg/cmd/workspace/create/cmd.go index f5b1737e..0c937318 100644 --- a/pkg/cmd/workspace/create/cmd.go +++ b/pkg/cmd/workspace/create/cmd.go @@ -29,9 +29,6 @@ func NewCmd() *cobra.Command { DisableFlagsInUseLine: true, RunE: func(cmd *cobra.Command, args []string) (err error) { defer util.RecoverErr(&err) - if err != nil { - return err - } util.CheckErr(o.Complete(args)) util.CheckErr(o.Validate()) util.CheckErr(o.Run()) diff --git a/pkg/cmd/workspace/del/cmd.go b/pkg/cmd/workspace/del/cmd.go index 8a1a865b..50aa790e 100644 --- a/pkg/cmd/workspace/del/cmd.go +++ b/pkg/cmd/workspace/del/cmd.go @@ -29,9 +29,6 @@ func NewCmd() *cobra.Command { DisableFlagsInUseLine: true, RunE: func(cmd *cobra.Command, args []string) (err error) { defer util.RecoverErr(&err) - if err != nil { - return err - } util.CheckErr(o.Complete(args)) util.CheckErr(o.Validate()) util.CheckErr(o.Run()) diff --git a/pkg/cmd/workspace/list/cmd.go b/pkg/cmd/workspace/list/cmd.go index 1f93a05f..048776c0 100644 --- a/pkg/cmd/workspace/list/cmd.go +++ b/pkg/cmd/workspace/list/cmd.go @@ -35,9 +35,6 @@ func NewCmd() *cobra.Command { DisableFlagsInUseLine: true, RunE: func(cmd *cobra.Command, args []string) (err error) { defer util.RecoverErr(&err) - if err != nil { - return err - } util.CheckErr(Validate(args)) util.CheckErr(Run()) return diff --git a/pkg/cmd/workspace/show/cmd.go b/pkg/cmd/workspace/show/cmd.go index 76f0d660..78ffc155 100644 --- a/pkg/cmd/workspace/show/cmd.go +++ b/pkg/cmd/workspace/show/cmd.go @@ -29,9 +29,6 @@ func NewCmd() *cobra.Command { DisableFlagsInUseLine: true, RunE: func(cmd *cobra.Command, args []string) (err error) { defer util.RecoverErr(&err) - if err != nil { - return err - } util.CheckErr(o.Complete(args)) util.CheckErr(o.Validate()) util.CheckErr(o.Run()) diff --git a/pkg/cmd/workspace/update/cmd.go b/pkg/cmd/workspace/update/cmd.go index 92d50107..bf6918f2 100644 --- a/pkg/cmd/workspace/update/cmd.go +++ b/pkg/cmd/workspace/update/cmd.go @@ -29,9 +29,6 @@ func NewCmd() *cobra.Command { DisableFlagsInUseLine: true, RunE: func(cmd *cobra.Command, args []string) (err error) { defer util.RecoverErr(&err) - if err != nil { - return err - } util.CheckErr(o.Complete(args)) util.CheckErr(o.Validate()) util.CheckErr(o.Run())