Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue to replace pod by label when encountering replace update #210

Closed
ColdsteelRail opened this issue May 28, 2024 · 0 comments
Closed
Assignees
Labels
kind/bug Something isn't working kind/enhancement New feature or request

Comments

@ColdsteelRail
Copy link
Collaborator

ColdsteelRail commented May 28, 2024

Minimal reproduce step

  1. prepare a collaset with 1 replicas
  2. replace the pod using podopslifecycle.kusionstack.io/to-replace label
  3. at the same time, update collaset with replace update

pod replace is forced to be finished by deleting replace new pod, and encountering endless reconcling bug
replace-bug

for inplace update

for recreate update

What did you expect to see?

replace update do not start until replace pod finished

What did you see instead

replace update and pod replace execute at the same time, encountering bug

What is your KusionStack components and its version?

latest, main

@ColdsteelRail ColdsteelRail added the kind/bug Something isn't working label May 28, 2024
@ColdsteelRail ColdsteelRail assigned wu8685 and ColdsteelRail and unassigned wu8685 May 28, 2024
@ColdsteelRail ColdsteelRail changed the title Bug: endless reconciling if do replace update and replace simultaneusly Bug: endless reconciling if do replace update and pod replace simultaneusly May 28, 2024
@ColdsteelRail ColdsteelRail added the kind/enhancement New feature or request label May 29, 2024
@ColdsteelRail ColdsteelRail changed the title Bug: endless reconciling if do replace update and pod replace simultaneusly Enhancement: continue to replace pod when encountering inPlace/recreate/replace update May 29, 2024
@ColdsteelRail ColdsteelRail changed the title Enhancement: continue to replace pod when encountering inPlace/recreate/replace update Enhancement: continue to replace pod when encountering replace update May 29, 2024
@ColdsteelRail ColdsteelRail changed the title Enhancement: continue to replace pod when encountering replace update Continue to replace pod when encountering replace update May 29, 2024
@ColdsteelRail ColdsteelRail changed the title Continue to replace pod when encountering replace update Bug: Continue to replace pod by label when encountering replace update May 29, 2024
@ColdsteelRail ColdsteelRail changed the title Bug: Continue to replace pod by label when encountering replace update Continue to replace pod by label when encountering replace update May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants