Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: delay clear pd finalizer and delete invalid printcolumn #238

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

Eikykun
Copy link
Member

@Eikykun Eikykun commented Aug 5, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references:

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

PodDecoration

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Fix:

  1. Delay clear pd finalizer: delete finalizer after all pods escape to ensure cls get old pd controllerrevision.
  2. Delete poddecoration 'EFFECTIVE' printcolumn

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Eikykun Eikykun changed the title Fix: delay clear pd finalizer Fix: delay clear pd finalizer and delete invalid printcolumn Aug 5, 2024
@Eikykun Eikykun self-assigned this Aug 5, 2024
Copy link
Member

@ColdsteelRail ColdsteelRail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikykun Eikykun merged commit d0e6766 into KusionStack:main Aug 5, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants