Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gson relocation causes reflection not working #176

Open
re-ovo opened this issue Jun 10, 2024 · 2 comments
Open

Gson relocation causes reflection not working #176

re-ovo opened this issue Jun 10, 2024 · 2 comments
Labels
type: bug Something isn't working

Comments

@re-ovo
Copy link
Contributor

re-ovo commented Jun 10, 2024

Currently, there are some reflection parts that use the Gson class directly without considering the impact of relocation, which will cause it to not work, such as MinecraftComponentSerializer.

Perhaps make a utility class can be implemented to convert between the relocated Gson and the built-in Gson?

@kezz
Copy link
Member

kezz commented Jun 10, 2024

I would just consider not shading and relocating GSON.

@kezz kezz added the type: bug Something isn't working label Jun 10, 2024
@mbax
Copy link

mbax commented Jun 26, 2024

For folks in such a situation, unable to get out of shading gson or at least needing more time: You can avoid this by doing your shading/relocating of gson as one step and then shading and relocating adventure-platform in a second step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants