Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically generate proper RDF of repeatable literals #321

Closed
jgreben opened this issue Feb 1, 2019 · 1 comment
Closed

Dynamically generate proper RDF of repeatable literals #321

jgreben opened this issue Feb 1, 2019 · 1 comment

Comments

@jgreben
Copy link
Contributor

jgreben commented Feb 1, 2019

When removing a literal value from a repeatable field, RDF reducer should properly remove values and re-generate the RDF. Currently, after adding multiple literals (e.g. "A", "B", and "C") when you remove a value (by clicking the "x"), the RDF generation remains the same:

{
  "@context": {
    "rdf": "http://www.w3.org/1999/02/22-rdf-syntax-ns#",
    "rdfs": "http://www.w3.org/2000/01/rdf-schema#",
    "xsd": "http://www.w3.org/2001/XMLSchema#",
    "bf": "http://id.loc.gov/ontologies/bibframe/",
    "bflc": "http://id.loc.gov/ontologies/bflc/",
    "madsrdf": "http://www.loc.gov/mads/rdf/v1#",
    "pmo": "http://performedmusicontology.org/ontology/"
  },
  "@graph": [
    {
      "@id": "_:n3-0",
      "@type": "http://id.loc.gov/ontologies/bibframe/Instance",
      "http://id.loc.gov/ontologies/bibframe/issuance": {
        "@id": "http://id.loc.gov/vocabulary/issuance/mono"
      },
      "http://id.loc.gov/ontologies/bibframe/carrier": {
        "@id": "http://id.loc.gov/vocabulary/carriers/nc"
      },
      "http://id.loc.gov/ontologies/bibframe/responsibilityStatement": [
        "A",
        "B",
        "C"
      ]
    },
    {
      "@id": "http://id.loc.gov/vocabulary/issuance/mono",
      "@type": "http://id.loc.gov/ontologies/bibframe/issuance",
      "rdfs:label": "single unit"
    },
    {
      "@id": "http://id.loc.gov/vocabulary/carriers/nc",
      "@type": "http://id.loc.gov/ontologies/bibframe/carrier",
      "rdfs:label": "volume"
    }
  ]
}

Note: Adding values works fine.

@jermnelson
Copy link
Contributor

Closing; fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants