Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Definitions for InpaintGenerator_S() and InpaintGenerator_P() in test.py #4

Open
AnkitAI07 opened this issue Jul 18, 2024 · 1 comment

Comments

@AnkitAI07
Copy link

While running test.py, I encountered a problem where the definitions for InpaintGenerator_S() and InpaintGenerator_P() were not found. The relevant code snippet is as follows:

if args.type == 'BSCVR_S': model = net.InpaintGenerator_S().to(device) elif args.type == 'BSCVR_P': model = net.InpaintGenerator().to(device)

Questions:

  1. Is there a significant difference between InpaintGenerator() and the missing InpaintGenerator_S() and InpaintGenerator_P() in terms of functionality? Could you please elaborate on this?

  2. The supplementary materials mentioned in the paper are not available. Could you provide an estimated date for when these materials will be available or a link where they can be accessed?

Thank you for your assistance.

@LIUTIGHE
Copy link
Owner

LIUTIGHE commented Jul 19, 2024

Hi thanks for pointing out those issues, I have updated the model file and test scripts. It should work now.

  1. Functionally speaking, S and P don't have significant differences. They are just two kinds of basic self-attention implementation to achieve feature completion via treating the tokens in sequence as vanilla Transformer or divide into patches refering to SwinTransformer.
  2. You can check the supplementary materials here, and I have update readme as well.

Thanks again for your checking, to be honest I am working on another urgent project now and I didn't make detailed checking. So if you encounter further problems, feel free to leave your issue here and I would be glad to amend the code for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants