Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could I make a PR for using Meson Builder? #14

Open
AtilaSaraiva opened this issue Oct 27, 2021 · 5 comments
Open

Could I make a PR for using Meson Builder? #14

AtilaSaraiva opened this issue Oct 27, 2021 · 5 comments

Comments

@AtilaSaraiva
Copy link

Hello good sir,
I love your project, as it makes opencl significantly easier to work with, competing directly with the likes of cuda, sycl, and rocm-hip.

I'd like to start using it heavily on my research, but it would be too much of a hassle to use makefiles. It would be nice if I could just use your repository as a Meson subproject. It will import all of the library, and the compiler flags will then be handled automaticaly. It is a genius piece of work.

Of course I can always make a fork and maintain it in parallel, but it would only undermine your efforts, so I looking for the collaboration route.

Thx for your brilliant work!

@LKedward
Copy link
Owner

Hi Átila @AtilaSaraiva, thanks for the kind feedback, I'm glad you've found it useful!
Yes, incorporating makefiles is quite a hassle and I would be definitely welcome a PR to make this Meson compatible!
Would you be willing to also make a small addition to the documentation (https://github.com/LKedward/focal-docs) to explain how to use it with Meson?
Let me know if you have any questions, I look forward to your PR.

@AtilaSaraiva
Copy link
Author

AtilaSaraiva commented Oct 28, 2021

Of course, I will start working on it as soon I finish the paper I am writing. I'll let you know once I start the hands on phase.
I feel much more at ease knowing you're that cooperative, thanks a lot!

@AtilaSaraiva
Copy link
Author

Hello again! I got too excited and started working on it last night, and I came across a problem. I can compile the library just fine, but all the tests and examples use the

ld -r -b binary fclKernels.cl ...

which results in a limitation that the command has to be run inside the folder on which the fclKernels.cl file is, otherwise the symbol name in the resulting object will have a name with the full path, which the current function written at Focal_utils.f90 cannot handle.

Now comes a question, how feasible it is to addapt the code to handle any symbol name with path or not?

thx for your time.

@AtilaSaraiva
Copy link
Author

#15 Published! please take a look 👯‍♂️

@AtilaSaraiva
Copy link
Author

Hello again! Is it possible to us to have some sort of direct communication? I'd like to discuss some ideas for the project.

Here is my personal email: atilasaraiva@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants