Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete implementations of GPU basic reducer constructor test #1474

Merged
merged 5 commits into from
May 4, 2023

Conversation

rchen20
Copy link
Member

@rchen20 rchen20 commented May 3, 2023

Summary

@rhornung67
Copy link
Member

@rchen20 please don't merge this. Something is more broken here than it is on develop.

@rchen20
Copy link
Member Author

rchen20 commented May 3, 2023

@rchen20 please don't merge this. Something is more broken here than it is on develop.

I won't merge yet, but I doubt this PR is causing the linker warnings on Tioga because nothing here touches that. I'm running the CI on develop in another PR to check the Tioga output that we should expect #1476.

@rchen20
Copy link
Member Author

rchen20 commented May 3, 2023

@rchen20 please don't merge this. Something is more broken here than it is on develop.

I won't merge yet, but I doubt this PR is causing the linker warnings on Tioga because nothing here touches that. I'm running the CI on develop in another PR to check the Tioga output that we should expect #1476.

@rhornung67 Comparing the Tioga output from #1476 and this PR, they are roughly the same, except the failing test now passes. What occurs is that the ROCM/5.1.1 tests build, run, and pass with the linker warning spew. In the subsequent ROCM/5.2.3 build, the linker spew exceeds the log limit. This PR does not seem to affect the Tioga pipeline's excessive readelf warnings.

@adrienbernede
Copy link
Member

Merged in #1434 and working. Thank you!

@adrienbernede
Copy link
Member

@rhornung67 I think this could be merged into develop regardless of the CI branch. This PR addresses a bug affecting others (and develop).

@rhornung67
Copy link
Member

Right. Robert will merge it. Later today, I'm going to look into the Spack config file that is generated for the build space issues. When I manually run CMake with the ROCm versions used on corona and tioga and compile, I don't see any of those warnings. I have a hunch that we may need to fiddle with the Spack spec for those builds.

@rchen20 rchen20 merged commit c1ff3a6 into develop May 4, 2023
@rchen20 rchen20 deleted the bugfix/chen59/reducerconstructor branch May 4, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants