Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "tunings" Command Line Option #333

Conversation

michaelmckinsey1
Copy link
Contributor

@michaelmckinsey1 michaelmckinsey1 commented Jun 12, 2023

Add "tunings" Command Line Option

  • This PR is a feature.
  • It does the following:
    • Modifies the parser to accept "-t" or "--tunings" as a command line argument which allows the user to specify which tunings to run. If the argument is not provided it runs all tuning which follows the current behavior.
      • Ex: Instead of
      Base_CUDA-default
      Base_CUDA-block_128
      Base_CUDA-cub
      Base_CUDA-library
      
      we can add --tunings default block_128
      Base_CUDA-default
      Base_CUDA-block_128
      
    • This feature is at the request of the PAVE team.

src/common/Executor.cpp Outdated Show resolved Hide resolved
src/common/Executor.cpp Outdated Show resolved Hide resolved
@michaelmckinsey1 michaelmckinsey1 marked this pull request as ready for review June 14, 2023 18:05
src/common/Executor.cpp Outdated Show resolved Hide resolved
Co-authored-by: Jason Burmark <MrBurmark@users.noreply.github.com>
src/common/Executor.cpp Outdated Show resolved Hide resolved
Co-authored-by: Jason Burmark <MrBurmark@users.noreply.github.com>
src/common/Executor.cpp Outdated Show resolved Hide resolved
src/common/Executor.cpp Outdated Show resolved Hide resolved
@rhornung67
Copy link
Member

@MrBurmark i sent you a teams chat message about this. we need to pull the branch from the fork into the repo and make a companion PR so Gitlab CI will run on it.

@rhornung67 rhornung67 mentioned this pull request Jul 10, 2023
24 tasks
@rhornung67
Copy link
Member

@michaelmckinsey1 I merged the companion PR to this one. Shall I close this one?

@michaelmckinsey1
Copy link
Contributor Author

#335 merged. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants