Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR from fork/333 #335

Merged
merged 18 commits into from
Jul 24, 2023
Merged

PR from fork/333 #335

merged 18 commits into from
Jul 24, 2023

Conversation

michaelmckinsey1
Copy link
Contributor

@michaelmckinsey1 michaelmckinsey1 commented Jun 22, 2023

See #333

@michaelmckinsey1
Copy link
Contributor Author

michaelmckinsey1 commented Jun 22, 2023

@MrBurmark I'm guessing tests failed because of TOSS4 update? For example, ruby doesn't have that old gcc version anymore

     Versions:
        gcc/10.3.1-magic
        gcc/10.3.1
        gcc/11.2.1-magic
        gcc/11.2.1
        gcc/12.1.1-magic
        gcc/12.1.1

Where catalyst (TOSS3) does

     Versions:
        gcc/4.8-redhat
        gcc/4.9.3
        gcc/6.1.0
        gcc/7.1.0
        gcc/7.3.0
        gcc/8.1.0
        gcc/8.3.1
        gcc/9.3.1
        gcc/10.2.1

Have these tests been ran since ruby was updated?

@MrBurmark
Copy link
Member

@rhornung67 Have you seen these ruby test failures?

@rhornung67
Copy link
Member

I think @adrienbernede has this fixed in a PR. Maybe this one? #329. We pulled in the needed changes to RAJA and then RAJAPerf has to update to RAJA develop for everything to work.

@adrienbernede
Copy link
Member

There was some long due CI update in #254.
#329 is the fix for RHEL 8, that is done on top of the former.
254 has been reviewed and approved.
To my understanding only the CI issues were holding that PR.
I still have some intermittent failures though... working on that.

@rhornung67
Copy link
Member

@michaelmckinsey1 if we merge #254 into RAJAPerf develop, will that disrupt your work?

@michaelmckinsey1
Copy link
Contributor Author

michaelmckinsey1 commented Jun 22, 2023

@michaelmckinsey1 if we merge #254 into RAJAPerf develop, will that disrupt your work?

It shouldn't disrupt this PR, but #331 is directly conflicting with #254; it is a variant of the same work. I think we should discuss this Tuesday in the RAJA meeting.

@rhornung67
Copy link
Member

@michaelmckinsey1 if we merge #254 into RAJAPerf develop, will that disrupt your work?

It shouldn't disrupt this PR, but #331 is directly conflicting with #254; it is a variant of the same work. I think we should discuss this Tuesday in the RAJA meeting.

OK. ruby tests will continue to fail because changes for the RHEL8 upgrade are planned to come through #254. We may have to rethink the merge sequence. We need more traffic signals I think.... 😄

@michaelmckinsey1 michaelmckinsey1 mentioned this pull request Jul 11, 2023
24 tasks
@adrienbernede adrienbernede mentioned this pull request Jul 12, 2023
2 tasks
@michaelmckinsey1
Copy link
Contributor Author

michaelmckinsey1 commented Jul 20, 2023

@MrBurmark @rhornung67 Passing CI after rebase

@rhornung67
Copy link
Member

Excellent! I've been shepherding things along. LC platforms have been plugged up lately.

@rhornung67
Copy link
Member

rhornung67 commented Jul 20, 2023

@michaelmckinsey1 are you aware of this one? #348

@michaelmckinsey1
Copy link
Contributor Author

@michaelmckinsey1 are you aware of this one? #348

Is #348 the one we are merging?

@rhornung67
Copy link
Member

@michaelmckinsey1 I merged develop into this. When CI checks are all green, let's go ahead and merge this one.

@michaelmckinsey1
Copy link
Contributor Author

Looks like dev failing on the same tests

@rhornung67
Copy link
Member

tioga jobs timing out in the queue due to heavy system use. jobs restared.

Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelmckinsey1 CI checks are green on this one. Please feel free to merge.

@michaelmckinsey1
Copy link
Contributor Author

@rhornung67 GitHub is saying I'm not authorized to merge.

@rhornung67 rhornung67 merged commit 622ded9 into develop Jul 24, 2023
@rhornung67 rhornung67 deleted the pr-from-fork/333 branch July 24, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants