-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR from fork/333 #335
PR from fork/333 #335
Conversation
@MrBurmark I'm guessing tests failed because of TOSS4 update? For example, ruby doesn't have that old gcc version anymore
Where catalyst (TOSS3) does
Have these tests been ran since ruby was updated? |
@rhornung67 Have you seen these ruby test failures? |
I think @adrienbernede has this fixed in a PR. Maybe this one? #329. We pulled in the needed changes to RAJA and then RAJAPerf has to update to RAJA develop for everything to work. |
@michaelmckinsey1 if we merge #254 into RAJAPerf develop, will that disrupt your work? |
It shouldn't disrupt this PR, but #331 is directly conflicting with #254; it is a variant of the same work. I think we should discuss this Tuesday in the RAJA meeting. |
OK. ruby tests will continue to fail because changes for the RHEL8 upgrade are planned to come through #254. We may have to rethink the merge sequence. We need more traffic signals I think.... 😄 |
Co-authored-by: Jason Burmark <MrBurmark@users.noreply.github.com>
Co-authored-by: Jason Burmark <MrBurmark@users.noreply.github.com>
…names' and fix check
b5b2c49
to
e5fdfb5
Compare
@MrBurmark @rhornung67 Passing CI after rebase |
Excellent! I've been shepherding things along. LC platforms have been plugged up lately. |
@michaelmckinsey1 are you aware of this one? #348 |
Is #348 the one we are merging? |
@michaelmckinsey1 I merged develop into this. When CI checks are all green, let's go ahead and merge this one. |
Looks like dev failing on the same tests |
tioga jobs timing out in the queue due to heavy system use. jobs restared. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelmckinsey1 CI checks are green on this one. Please feel free to merge.
@rhornung67 GitHub is saying I'm not authorized to merge. |
See #333