Add adjoint load for the case of adjoints associated with resultant/dual forces. #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/style |
tupek2
force-pushed
the
tupek/reaction_sensitivities
branch
from
35042a3 to
a5d237b
Compare
|
/style |
|
/style |
…AdjointBcs to be a bit more mathly accurate.
tupek2
force-pushed
the
tupek/reaction_sensitivities
branch
from
f7b60a7 to
ab4ea41
Compare
|
/style |
tupek2
force-pushed
the
tupek/reaction_sensitivities
branch
from
5b678f7 to
a43765c
Compare
|
/style |
|
/style |
|
/style |
|
This enables a simpler and more consistent interface for reaction force sensitivities. Also, add function to fetch a previous reaction force vector. This is really recomputing it behind the scenes. |
btalamini
approved these changes
Oct 25, 2024
| @@ -1201,7 +1229,9 @@ class SolidMechanics<order, dim, Parameters<parameter_space...>, std::integer_se | |||
| std::unique_ptr<mfem::HypreParMatrix> m_mat(assemble(M)); | |||
|
|
|||
| // J = M + c0 * K | |||
| J_.reset(); | |||
There was a problem hiding this comment.
Is this fixing a bug? Because the heat transfer module still does it the old way. If so, can you open an issue?
| displacement_adjoint_load_ = disp_adjoint_load->second; | ||
| // Add the sign correction to move the term to the RHS | ||
| displacement_adjoint_load_ *= -1.0; | ||
| if (disp_adjoint_load != loads.end()) { |
There was a problem hiding this comment.
This check and the SLIC_ERROR_ROOT_IF above look like they're guarding the same problem. Can we combine these so that they don't get out of sync? Doesn't need to happen in this PR.
kswartz92
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.