-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide data in Domain
#1277
base: develop
Are you sure you want to change the base?
Hide data in Domain
#1277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, seems like we need to get that new formatting in. Its going crazy on these files.
I agree. In particular, the forced alignment of the right side of |
Let's hold this back until I get the boundary condition PR in. I'll handle the conflicts that emerge in this PR later. |
Following up on Mike's comment: this changes
Domain
from a struct to a class, with the expected hiding of internal data.