Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ZynAddSubFX multi-parametric EQ into a standalone LMMS effect plugin? #1520

Closed
unfa opened this issue Dec 27, 2014 · 16 comments
Closed

Comments

@unfa
Copy link
Contributor

unfa commented Dec 27, 2014

One of the features that I find extremely handy is the EQ that I find in ZynAddSubFX.

eq

· It has 8 toggleable filters of choosable type (much like in the Dual Filter effect) with f, Q, gain and # stages controls for each;
· It has a visual graph showing the whole frequency spectrum and what am I actually doing to my signal (once you learn to read the grid it's really easy to precisely read what are you doing);
· it's very compact pixelwise - the filters are not displayed in a list, but one switches between them (numbers 0 through 7) which at first seems a little daunting, quickly becomes very intuitive and fast.

We already have this in a LADSPA version, but the lack of graphical interface makes the charm of this unit go away. The most valuable feature in here is that I can see the frequency response curve on the frequency grid, and this helps a lot to quickly set up the EQ.

@tresf
Copy link
Member

tresf commented Dec 27, 2014

Are you aware of this?:
#1443

@unfa
Copy link
Contributor Author

unfa commented Dec 27, 2014

No, thanks for letting me know!

@badosu
Copy link
Contributor

badosu commented Dec 28, 2014

Is it possible to embed Calf plugins with their original interface?

For example this is what Calf 5-band equalizer looks like:

Calf 5-band equalizer

@tresf
Copy link
Member

tresf commented Dec 28, 2014

@badosu are you sure that is the "original" interface? We are quite far behind. The latest Calf isn't really a drop in to our code IIRC, so you may be comparing apples to oranges.

@tresf
Copy link
Member

tresf commented Dec 28, 2014

@unfa, safe to close?

@badosu
Copy link
Contributor

badosu commented Dec 28, 2014

@tresf We use the API interface (LADSPA) directly and just expose the knobs for each parameter on all Calf's plugins.

However take a look here: Ardour embeds the original Calf interface (starts at 0:41), but I am not aware how and if it can be done easily for lmms.

Take a look at Calf's project page here, you can see what's the original interface for each plugin like.

The latest Calf isn't really a drop in to our code IIRC, so you may be comparing apples to oranges.

Yeah, I know that we use Calf in a different way, that's why I just wanted to know the feasibilty for this change. LMMS would give a big leap in terms of quality for the plugins section (I feel like).

@mikobuntu
Copy link
Contributor

This is the LV2 ( LADSPA version 2 ) implementation of the Calf plugin. Iirc someone has started working on LV2 for LMMS, so hopefully this addition will be realised sometime ;)

thanks Mikobuntu ;)

@tresf We use the API interface (LADSPA) directly and just expose the knobs for the parameters for all Calf's plugins.

However take a look here: Ardour embeds the original Calf interface (starts at 0:41), but I am not aware how and if it can be done easily for lmms.


Reply to this email directly or view it on GitHub.

                  =

@diizy
Copy link
Contributor

diizy commented Dec 28, 2014

On 12/28/2014 06:57 AM, Amadeus Folego wrote:

Is it possible to embed Calf plugins with their original interface?

Not until we get LV2 support.

@diizy
Copy link
Contributor

diizy commented Dec 28, 2014

On 12/28/2014 09:25 AM, Tres Finocchiaro wrote:

@badosu https://github.com/badosu are you sure that is the
"original" interface?

The interface is in the DSSI/LV2 versions, we only have LADSPA which
aren't even maintained by the Calf team anymore. When we get LV2/DSSI
support, then we can have Calf plugins with GUIs.

@badosu
Copy link
Contributor

badosu commented Dec 28, 2014

@diizy @mikobuntu Wow, this is really promising! I hope we are able to make it some day 😄

@badosu
Copy link
Contributor

badosu commented Dec 28, 2014

Just found an issue that references this: #562

I guess we can close this issue as we are testing and the new EQ is looking good? /cc @unfa @tresf

@tresf
Copy link
Member

tresf commented Dec 29, 2014

Just found an issue that references this: #562

That may address your questions about Calf, but I think you're confusing the OP's topic here a bit. I've already asked @unfa if we can close this in regards to #1376 and awaiting his response.

@tresf
Copy link
Member

tresf commented Dec 29, 2014

Closing as duplicate of #1376. :) Please reopen @unfa if you believe this was closed in error. 👍

@tresf tresf closed this as completed Dec 29, 2014
@badosu
Copy link
Contributor

badosu commented Dec 29, 2014

@tresf You're right, I am sorry for introducing this subject on a semi-related issue, I just brought this up because I noticed @curlymorphic developed a whole parametric EQ plugin from the scratch.

It's not that it's not useful, it's already my favourite plugin on lmms! It's just that if we had already LV2 compatibility that would not be necessary, and we could focus development on different areas.

@tresf
Copy link
Member

tresf commented Dec 29, 2014

if we had already LV2 compatibility that would not be necessary, and we could focus development on different areas.

Perhaps, but dont underestimate the benefits of having a native anything. When something significant becomes part of the code, it tends to have a footprint that brings indirect impovements in other areas, as well as the benefits of learning. :)

@badosu
Copy link
Contributor

badosu commented Dec 29, 2014

@tresf Agreed, thanks for the insight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants