-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fast click crash while previewing sound presets. #2098
Comments
could you be more specific 'xpm' is that presets for a vst? |
xpf sorry https://lmms.io/lsp/?action=show&file=4211 here is a good example , happens more on complex sounds or when the system is thinking hard |
I can confirm this on commit 979fa2f
It either hangs or crashes with the above Qt comment. |
also confirmed on 1.1.3 win32 |
I seem to be getting a different error every time I try this on master w/ 64 bit Ubuntu 15.04. Half of the time it's a segfault in Here's one stacktrace for a segfault that occasionally occurs on the very first press (regardless of if I hold the mouse or just tap it):
Here's one where it hangs instead of crashing. This seems to reliably happen if I can tap
And stack-traces for the rest of the threads, if useful:
I'm gonna fiddle around with Valgrind and see if it reveals anything trivial for the first case. |
Here's the Valgrind log that I get when I click the .xpf file for the first time (it plays ok and does not crash - but that's probably just thanks to Valgrind): https://gist.github.com/Wallacoloo/f28e905edea6cb0102b1 All of the errors Valgrind catches point to essentially the same piece of code. Let's take this one:
If you'll notice, it looks like we're experiencing a similar name-conflict error in which Zyn's Indeed, gdb confirms this is the case:
Also, the offending line is this one, in NulEngine::NulEngine(): name = "NULL"; Notably, There could still be more at play than this classname conflict, but it potentially explains all the segfaults I saw - we definitely need to figure out the whole |
@Wallacoloo nice research As far as the engine name clash goes. In the ZSAF 2.5 upgrade, I moved the engine class to the Zyn namespace during my tidying up of the pull request over the weekend. |
@Umcaruje -where are we with this ? |
@musikBear this issue will be solved by either #1991 or #2064 or #2118. I can't quite understand your question though. If an issue is fixed, it will be closed. If its not fixed its open. This issue is open, which means its not fixed. |
Duplicate of #2269. |
if you click too fast while previewing sound preset xpm a crash occurs. a possible workaround could be to add a minimum play time to the previewing of xpm's
The text was updated successfully, but these errors were encountered: