Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins crash lmms due to name clash #2223

Closed
dsonck92 opened this issue Jul 29, 2015 · 2 comments
Closed

Plugins crash lmms due to name clash #2223

dsonck92 opened this issue Jul 29, 2015 · 2 comments

Comments

@dsonck92
Copy link

Currently I have the issue where showing the ZynAddSubFX plugin caused lmms to crash. When inspecting this issue with QtCreator and trying different Qt versions (even Qt5), I discovered that it crashed due to the deletion of m_ioEngine.

When inspecting the stack trace, the crash occurred because the deletion triggered the QObject destructor. Somehow AudioOut and/or MidiIn became a subclass of the global Engine which is in charge of keeping the lmms state, and not a subclass of the Engine defined in Nio/Engine.h. I decided to put the lmms engine in a namespace to make it hidden to NulEngine which then solved the issue.

It may be useful to check for name clashes or prevent them in advance by defining namespaces for different parts of lmms. I will look if I can make my current changes a bit more clean and perhaps define a namespace for the Nio/ classes rather than the lmms classes (given that more depend on lmms Engine than the nio Engine)

@tresf
Copy link
Member

tresf commented Jul 30, 2015

Thanks. On our radar per: #2064, #2118

@tresf tresf added the bug label Jul 30, 2015
@tresf tresf added this to the 1.2.0 milestone Jul 30, 2015
@Umcaruje Umcaruje added the core label Jul 30, 2015
@tresf
Copy link
Member

tresf commented Aug 22, 2015

Duplicate of #2269

@tresf tresf closed this as completed Aug 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants