Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample tracks shortened at >44100 samplerate export #2778

Closed
Spekular opened this issue May 14, 2016 · 9 comments
Closed

Sample tracks shortened at >44100 samplerate export #2778

Spekular opened this issue May 14, 2016 · 9 comments

Comments

@Spekular
Copy link
Member

Spekular commented May 14, 2016

Found in 1.1.9.0-g0-c9bf9b. Exporting a track at above 44100 samplerate will cause sample tracks to stop playback earlier than they should. They do, however, retain the correct playback speed.

Correct: https://drive.google.com/open?id=0BxmQmjduN8QxTUpNS0hSX3N6MlE
Incorrect: https://drive.google.com/open?id=0BxmQmjduN8QxalNUejNBV1BqSjQ

@Spekular
Copy link
Member Author

Updated.

@Umcaruje
Copy link
Member

We should really disable the sample tracks. There's just so much wrong with them that a complete rewrite is probably necessary.

@Spekular
Copy link
Member Author

Spekular commented May 16, 2016 via email

@softrabbit
Copy link
Member

I think this was the first LMMS bug I reported back in 0.4.5 or so, long before I contributed any code... sweet memories 😄. Guess it never got fixed, then.

IIRC, playback is OK but export is buggy, do you agree @Spekular?

@Spekular
Copy link
Member Author

Spekular commented May 16, 2016

@softrabbit yup.

@tresf
Copy link
Member

tresf commented May 16, 2016

Possible duplicate of #1471 (comment)

What ways are they broken in aside from this?

#1471

@Spekular
Copy link
Member Author

@tresf I suppose I ought to close this and consider it part of the meta-issue?

@tresf
Copy link
Member

tresf commented May 16, 2016

@tresf I suppose I ought to close this and consider it part of the meta-issue?

Probably. >44.1K isn't all that popular of a format and AFAIK we have some other issues that crop up >44.1K as well.

@Spekular
Copy link
Member Author

Consolidated into #1471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants