Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation points tooltips can show outside of the automation editor border & window. #3746

Closed
husamalhomsi opened this issue Aug 2, 2017 · 4 comments

Comments

@husamalhomsi
Copy link
Member

Dragging or dragging & releasing an automation point shows a tooltip with its value. The issue is that this can happen outside the automation editor border & window.

Outside the automation editor border:
image
Outside the automation editor window:
image

The above tooltips showed after dragging an automation point and releasing (by releasing left mouse-button) outside the automation editor border & window.

I suggest setting limits on where automation points tooltips can show.
My suggested limit is the automation editor border, the one highlighted in yellow in this image:
snip_20170802184919

@zonkmachine
Copy link
Member

Confirmed.

@zonkmachine zonkmachine added the ux label Aug 2, 2017
@husamalhomsi
Copy link
Member Author

husamalhomsi commented Aug 3, 2017

I think this is related:
clicking on any of the highlighted buttons in the image below shows a tooltip with the max value of the automated parameter in it. In this case, it's 1.
unknown

@PhysSong
Copy link
Member

I suggest setting limits on where automation points tooltips can show.
My suggested limit is the automation editor border, the one highlighted in yellow in this image:

Good! You may add a coordinate check in AutomationEditor::drawCross.

@husamalhomsi
Copy link
Member Author

@PhysSong Thanks for the hint! PR ready: #4308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants