Midi events are modified by the MidiClients

[gi0e5b06]

Most of the Midi clients modify the events in some way. For example:

• shifting one octave down
• computing pitchbend in different ways

The Midi events should never be altered.

1. Fix the funky design of MidiEvent
2. remove any shifting
3. uniformize pitchbending, panning, volume, etc
4. prefix setter/getter for LMMS with lmms
5. unprefix setter/getter for MIDI

[PhysSong]

• shifting one octave down

See #1857 (comment).

• computing pitchbend in different ways

What do you mean there?

[PhysSong]

1. Fix the funky design of MidiEvent

Why do you think the design of MidiEvent is funky? When you say "funky", there should be a reason for that.

4. prefix setter/getter for LMMS with lmms
5. unprefix setter/getter for MIDI

Well, I think this can be a problem with conventions and consistency. Does the new suggestion have any merits or needs?

[gi0e5b06]

My branch has all of these issues fixed.

0a. #1857 So this is another one of these very old bugs. A major one but easy to fix.
0b. Midi pitchbend should be a value between 0 and 16383. Also it should be stored in 2x7bit LE.

1. I used "funky" insead of "bad" because of @tresf :) Anyway, MidiEvent should follow the Midi standard. Internal data should be easy to write to a midi byte stream.
   4+5. I'm fine with the Qt convention (no 'get' but 'set' prefixes). Here I'm talking about the 'midi' and 'lmms' prefixes. MidiEvent.channel() should return the midi channel, while lmmsChannel() should return the value for LMMS. Same for every thing else (volume, pitchbend, etc).