Dragging up/down vertical piano results in stuck notes.

[programnoir]

Steps to reproduce:

1. Create a piano pattern on the song editor or beat/bassline editor.
2. Drag mouse down the piano keys.

Expected behavior: Each key presses and releases as I go up and down the piano.

Actual result: Multiple piano keys graphically remain pressed (the keys do not audibly stick)

[ubailey1]

I can confirm this problem as well. It seems to be random, like every other loop, some keys dont' play sound

[musikBear]

Not in win32 1.2.0 rc8 (tested in both SE ans B&E contained PRoll)
Is this with a specific VST?
Please retry with default presets

[DomClark]

Reproduced.

@musikBear This is in 1.2.0, not 1.2.0-rc8. Please update to the latest version.

[ubailey1]

I tested in version 1.2

[BaraMGB]

It's this commit: 461facc
@DomClark can you have a look at this?

[DomClark]

I think it's a threading issue - previously all MIDI events relating to mouse input were sent from the UI thread, but since that commit some come from the processing thread too. I guess if one drags too quickly, the note-on arrives at the piano model after the note-off. Strangely, this doesn't seem to affect all instruments - single-streamed ones are fine, along with Mallets, Organic, sfxr, and Vibed. I'll investigate.

[enp2s0]

I also notice this issue, especially with zasfx. This occurs under both low and high CPU load, so it doesn't seem to be affected by it. Especially with my FadeButton patch, this bug is particularly annoying as it results in FadeButtons getting stuck in their held-note color even when no note is playing.

[karmux]

Related to #3005.

[zonkmachine]

Closed in #5127