Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoteVstPlugin crashes on loading/saving presets if it fails to open the file #5234

Closed
PhysSong opened this issue Oct 10, 2019 · 1 comment
Closed

RemoteVstPlugin crashes on loading/saving presets if it fails to open the file #5234

PhysSong opened this issue Oct 10, 2019 · 1 comment
Assignees
@PhysSong
Labels
bug development branch This issue affects the development branch(master) stable branch This issue applies to the latest stable
Milestone
1.2.1

Comments

@PhysSong
Copy link
Member

Regression probably introduced in #4401.
Previously, RemoteVstPlugin used read()/write() to read/write data to file. From #4401, it uses fread()/fwrite() instead. It seems like read()/write() just fails if the open() failed, but fread()/fwrite() crashes if the corresponding fopen() fails and return the null pointer.
I think it shouldn't be difficult to fix this bug.
@PhysSong PhysSong added the bug label Oct 10, 2019
@PhysSong PhysSong added this to the 1.2.1 milestone Oct 10, 2019
@PhysSong PhysSong self-assigned this Oct 10, 2019
@PhysSong PhysSong mentioned this issue Oct 10, 2019
Merged
@Reflexe Reflexe added master stable branch This issue applies to the latest stable labels Oct 12, 2019
@zonkmachine
Copy link
Member

Fixed in #5235

@PhysSong PhysSong added development branch This issue affects the development branch(master) and removed master labels Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhysSong PhysSong

Labels
bug development branch This issue affects the development branch(master) stable branch This issue applies to the latest stable
Projects
None yet
Milestone
1.2.1
Development

No branches or pull requests
3 participants
@zonkmachine @PhysSong @Reflexe