Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo/Redo of note edits via the menu is glitchy #5722

Closed
zonkmachine opened this issue Oct 19, 2020 · 1 comment · Fixed by #5789
Closed

Undo/Redo of note edits via the menu is glitchy #5722

zonkmachine opened this issue Oct 19, 2020 · 1 comment · Fixed by #5789
Labels
bug
Milestone
1.3

Comments

@zonkmachine
Copy link
Member

zonkmachine commented Oct 19, 2020 •
edited
Loading

When undoing/redoing note edits via the menu (under Edit) the action doesn't happen until you move the mouse back over the PianoRoll note window.

Steps to reproduce

  • Add some notes in the Piano Roll
  • Menu -> Edit -> undo
  • wait...
  • Move mouse over the notes and see the last one disappear

This affects the master branch and bisecting suggest that #5499, 5d7e672 is where the problem started.

commit 5d7e672

Automatically assign a midi input device to the selected track (#5499)

Bump @LNooteboom :)
@zonkmachine zonkmachine added this to the 1.3 milestone Oct 24, 2020
@thmueller64 thmueller64 mentioned this issue Nov 16, 2020
Merged
@thmueller64
Copy link
Contributor

Thank you for sorting out the relevant commit. Could you try this simple fix?

@DomClark DomClark linked a pull request Nov 17, 2020 that will close this issue
Fix glitch in undo/redo of note edits via the menu #5789
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Fix glitch in undo/redo of note edits via the menu thmueller64/lmms
2 participants
@zonkmachine @thmueller64