Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to see what sample is loaded in SlicerT #7060

Closed
SalutanisOrkonus opened this issue Jan 11, 2024 · 3 comments · Fixed by #7453
Closed

Ability to see what sample is loaded in SlicerT #7060

SalutanisOrkonus opened this issue Jan 11, 2024 · 3 comments · Fixed by #7453

Comments

@SalutanisOrkonus
Copy link

Enhancement Summary

SlicerT, great addition! One problem, though. Occasionally I like going through my projects and writing down what I used in each, SlicerT makes this a bit difficult though, because unless I'm missing something, there's nowhere it tells you what sample the instance has loaded.

Justification

It would make working with it a bit easier. Remember a drumloop you used in SlicerT in an old song you wanna use again, but don't remember where it is or what its called? This would make it a LOT easier to find it again.

Mockup

I'm no UI designer, so I don't actually know specifically how to go about it. I'd say something like "Click the SlicerT logo in the middle to pull up the sample select popup window", but that doesn't actually work and show you where what's selected is half the time for some reason, so if you wanna do it that way you'd have to fix that problem.

@zonkmachine
Copy link
Member

I'm also not into UI design but this could need some attention. Maybe the file name of the loaded sample could be shown in the top of the seeker window? @DanielKauss Maybe, when you find some time, you would like to look into this?

@thismoon
Copy link

thismoon commented Jun 6, 2024

for now you can find the paths of all the slicerT instruments in a project using this command

lmms -d "project.mmpz" | grep '<slicert' | grep -Po 'src="\\K.*?(?=")'

(if it starts with usersample: that's your default samples folder)

here's a simple UI mockup i made inspired by the sample track:
mockup 1
here's another more complex mockup that changes the layout of the plugin by adding a button to select a sample since it's absent too:
mockup 2
some other changes that i suggest:

  • change the copy midi icon to make its purpose clearer
  • set the instrument name to the sample file name when loaded (like audiofileprocessor)

@RoxasKH
Copy link
Contributor

RoxasKH commented Jun 6, 2024

I'm sorry i haven't noticed this issue until now.

Actually this was being worked by someone, and i made an UI for it which i posted on Discord 3/4 months ago, which is also reflected in the art resource file i've pushed for this PR on the artwork repo (LMMS/artwork#22).
I'm believing this someone either dropped it or well spaused the work on it for a long time.

Not knowing about an open issue, i didn't mirror post it on github.

Anyways, here it is:

Before After
before after

P.S: If anyone needs the discord message link to check the discussion about it here it is (https://discord.com/channels/203559236729438208/332258319228207114/1207823233890386020)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants