Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply DCR for faint objects #455

Open
rmjarvis opened this issue Mar 21, 2024 · 1 comment
Open

Apply DCR for faint objects #455

rmjarvis opened this issue Mar 21, 2024 · 1 comment

Comments

@rmjarvis
Copy link
Contributor

@esheldon discovered a bug in our rendering of very faint objects. We currently skip over the photon ops if the flux is < 100 photons. This is mostly fine, since we don't care if these objects have all the fine details of the sensor effects and such. However, if we are applying DCR as a photon op (as we typically do), this puts the faint objects in the wrong place. They don't have DCR applied to them.

This bit Erin when he used the output catalog to refit a more accurate WCS, including the DCR effect. He used all of the output objects' image and sky positions. But the majority of objects didn't have DCR applied, so their positions were systematically wrong, and the resulting WCS was pretty bad. Limiting the refit to flux > 100 fixed the problem, but we should find a way to get the faint objects in the right place to avoid this "feature" biting someone else in the future.

@esheldon
Copy link
Contributor

Is there a need to skip photon ops for objects with less than 100 photons?

If they only have 100 photons, will they be fast in any case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants