Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverTime behavior action is skill ID #16

Open
Xiphoseer opened this issue Apr 25, 2022 · 0 comments
Open

OverTime behavior action is skill ID #16

Xiphoseer opened this issue Apr 25, 2022 · 0 comments

Comments

@Xiphoseer
Copy link
Collaborator

LUDevNet/lu-explorer#106

The match_action_key currently always considers action to be a behavior ID, which is not true for Over Time (12) behaviors. We may need to pass the behaviorType as well and special-case that.

cf.

if match_action_key(parameter_id) {
let value = bp.value() as i32;
behaviors.entry(behavior_id).or_default().uses.insert(value);
behaviors
.entry(value)
.or_default()
.used_by
.insert(behavior_id);
}

pub fn match_action_key(key: &Latin1Str) -> bool {
matches!(
key.as_bytes(),
b"action"
| b"behavior 1"

@Xiphoseer Xiphoseer changed the title OneTime behavior action is skill ID OverTime behavior action is skill ID Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant