Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile LWJGL's version information into Java module descriptors #685

Closed
sormuras opened this issue Oct 7, 2021 · 1 comment
Closed

Comments

@sormuras
Copy link
Contributor

sormuras commented Oct 7, 2021

Description

Let the compiled module descriptors of modules provided this project contain version information.

Java/JDK modules (and other libraries/frameworks) do contain such information, which leads to printouts like the following from a custom runtime image:

java --list-modules

com.github.sormuras.bach.lwjgl@1
java.base@17
jdk.unsupported@17
org.lwjgl
org.lwjgl.glfw
org.lwjgl.glfw.natives
org.lwjgl.natives
org.lwjgl.opengl
org.lwjgl.opengl.natives

In addition, those versions are included in generated stacktraces: https://twitter.com/rotnroll666/status/1446126805404905491

Proposed version string patterns:

  • nightly org.lwjgl@3.3-nightly+2021.10.07
  • stable org.lwjgl@3.3-stable+2021.10.07
  • release org.lwjgl@3.3
@Spasi
Copy link
Member

Spasi commented Oct 11, 2021

Great idea @sormuras, thanks! LWJGL build information is now included in module descriptors, starting with 3.3.0 snapshot 15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants