Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cip.h: use htons/ntosh for SetPort()/GetPort() #204

Open
jg1uaa opened this issue Nov 1, 2021 · 0 comments
Open

cip.h: use htons/ntosh for SetPort()/GetPort() #204

jg1uaa opened this issue Nov 1, 2021 · 0 comments

Comments

@jg1uaa
Copy link

jg1uaa commented Nov 1, 2021

SetPort() and GetPort() in cip.h directly handles the value of struct sockaddr_in.
https://github.com/LX3JL/xlxd/blob/master/src/cip.h#L51
https://github.com/LX3JL/xlxd/blob/master/src/cip.h#L54

CUdpSocket::Open() stores uiPort value via htons().
https://github.com/LX3JL/xlxd/blob/master/src/cudpsocket.cpp#L64

Is there any reason to omit htons()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant