Issue 47257: Cannot delete samples from a grid that has a filter applied #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionKey based call to getCrossFolderSelectionResult() and getDeleteConfirmationData()
4 tasks
labkey-susanh
approved these changes
Feb 14, 2023
cnathe
added
TeamCity test review complete
and removed
needs TeamCity test review
labels
This was referenced Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=47257
There are two API actions that we do in our apps that make use of the snapshotSelections: getCrossFolderSelectionResult() and get[Entity]OperationConfirmationData(). In the case where these APIs are called using a selectionKey to get the selected row's primary keys, it is important that the call to setSnapshotSelections() has been made if there were also grid/model filters applied by the user. This PR adds those calls to setSnapshotSelections() to the various usages.
Related Pull Requests
Changes