Update #18
Update #18
Conversation
| createGroup() { | ||
| const group = this.fb.group({}); | ||
| this.controls.forEach(control => group.addControl(control.name, this.createControl(control))); | ||
| this.controls.forEach(control => { | ||
| if (!control.custom) group.addControl(control.name, this.createControl(control)); |
There was a problem hiding this comment.
@kyxyes I'm not seeing the test coverage on Coveralls.io. Could you take a look please?
There was a problem hiding this comment.
@KalleV Where or how could I see the test coverage on Coveralls.io?
There was a problem hiding this comment.
@kyxyes There should be a link in the PR status checks.
There was a problem hiding this comment.
There was a problem hiding this comment.
@KalleV Ok, but I saw the coverage results from travis build https://travis-ci.com/LabShare/ngx-forms/jobs/130848006
There was a problem hiding this comment.
@kyxyes That's good, it means the test coverage is being generated in some form, but it seems to not be recognized by Coveralls based on the status of Coverage remained the same at ?% and the empty report.
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.