Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credit to the thumbnail #9

Closed
r-brown opened this issue Feb 28, 2015 · 8 comments
Closed

Add credit to the thumbnail #9

r-brown opened this issue Feb 28, 2015 · 8 comments
Assignees
Labels
enhancement hacktoberfest Hacktoberfest ready issue ready

Comments

@r-brown
Copy link
Member

r-brown commented Feb 28, 2015

Add the credit to the image from thumbnail (the featured image) that reappears at the top of the actual post.

@r-brown r-brown self-assigned this Feb 28, 2015
@r-brown r-brown added the ready label Aug 31, 2015
@r-brown
Copy link
Member Author

r-brown commented Feb 24, 2016

Hi, we'd like to automatically show the image credit on (or just below) the post's featured image, just as here: http://prntscr.com/a759en or here: http://prntscr.com/a6ma3l how can we accomplish that?

source: https://wordpress.org/support/topic/image-credit-on-featured-image

@r-brown r-brown added the hacktoberfest Hacktoberfest ready issue label Oct 2, 2017
@Jaace
Copy link
Contributor

Jaace commented Oct 19, 2017

I can look into this.

@Jaace
Copy link
Contributor

Jaace commented Oct 19, 2017

A few questions: should the credit be just the Author/Owner field on the image or a combination of the fields, like: author/owner, source, publisher?

From the screenshot it looks like maybe just the author and the publisher?

Additionally, does this feature need to have an option to choose above/below the photo for this information? If we go down that path, we'd probably need to add a color setting so that if it's over the photo the text is visible, if it's light or dark.

@Jaace
Copy link
Contributor

Jaace commented Oct 19, 2017

PR opened here: #27

Let me know about the question above and I can modify to pull in the other data, if needed.

@r-brown
Copy link
Member Author

r-brown commented Oct 19, 2017

Hi @Jaace - thank you for your support & contribution.
We need to use Copyright format while rendering image caption texts on the websites. As the Copyright format is defined by user, he is free to choose any of available placeholders (e.g. %author%, %license%, %ident_nr%, etc.).

credit-tracker-copyright-format

@Jaace
Copy link
Contributor

Jaace commented Oct 20, 2017

Absolutely, I can look into that this weekend!

@Jaace
Copy link
Contributor

Jaace commented Oct 21, 2017

@r-brown I've pushed up changes to address the use of the copyright format field. The PR has been updated here: #27

Thanks!

@r-brown
Copy link
Member Author

r-brown commented Oct 21, 2017

Additional fine-tunings:

  • move logic to the credit-tracker-shortcodes.php
  • add the switch to allow enable disable thumbnail credit rendering (default: true)
  • fix error due to the missing thumbnail image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hacktoberfest Hacktoberfest ready issue ready
Development

No branches or pull requests

3 participants