Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique base defenses roll #189

Closed
worldendDominator opened this issue Feb 1, 2023 · 2 comments
Closed

Unique base defenses roll #189

worldendDominator opened this issue Feb 1, 2023 · 2 comments

Comments

@worldendDominator
Copy link

The bar and percentage for base defenses roll on uniques counts from zero to maximum roll, which means it never goes below 85%. You can instead utilize the whole range by counting from minimum roll, the same way as BaseDefensePercentile property on trade site and in loot filter.

For example:
Steel kite shield has base armor range 146 to 167, my shield has 147. The overlay displays it as 88% = 147 / 167. With proposed change, it will display as 5% = (147-146) / (167-146).
Mirrored spiked shield has base evasion range 151 to 174, mine has 168. The overlay shows 97% = 168 / 174. With proposed change, it will be 74% = (168-151) / (174-151).

@Lailloken
Copy link
Owner

Huh, I didn't know the trade site calculates it that way. I chose the current method because I felt that taking the absolute range as the basis and displaying such low percentages introduces unnecessary negative bias towards an item when the discrepancy between min and max is rather insignificant in reality (like the 20 armor in your example, and many others).

Another factor was data-base size: holding ALT in game shows the range of that roll, but it's not included when copying the item-info into clipboard. I had to build a custom data-base for item-bases, and I tried to keep it minimal in order to also keep loading-time low.

Thanks for bringing this to my attention, I'll do some testing. It's probably better to change it to be in line with official calculations. I really appreciate the inputs/suggestions I have received from you.

@Lailloken
Copy link
Owner

Alright, I have implemented the necessary changes. They'll be part of the next release.
Untitled 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants