Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't Work With Latest Sodium Commits (If you were to compile a build yourself) #6

Closed
ghost opened this issue Jul 20, 2020 · 6 comments
Labels
bug Something isn't working fixed The issue is fixed, if not closed then waiting for confirmation. sodium The issue is related to Sodium.

Comments

@ghost
Copy link

ghost commented Jul 20, 2020

Title mostly saids it all, if you compile a build of sodium from the latest GitHub Repo the game will crash with this when trying to load a world:

https://pastebin.com/xN7ymAuC

Version 1.0 on curseforge works just fine.

And if you want to see the crash for yourself here is the latest build from compiling: (removed)

@LambdAurora
Copy link
Owner

I could not reproduce the same crash but I successfully produced another crash with the latest Sodium commit, the incompability will be hopefully fixed for next release.

@ghost
Copy link
Author

ghost commented Jul 20, 2020

Hmmm, the only other mods I had installed was phosphor, lithium, mod menu, and fabric api. Other than that, thanks for taking notice.

(Once it gets fixes I'll close the issue)

@LambdAurora
Copy link
Owner

So, with LambDynamicLights 1.3.0 this issue become a bit complicated.

Sodium for 1.16.2 isn't out and the one that will be available should be based off the development versions and not the current stable versions iirc, so hopefully the fix should apply to those future versions.

@ghost
Copy link
Author

ghost commented Aug 18, 2020

There are some unoffical 1.16.2 support branches of sodium but I don't know if it works with LambDynamicLights yet: https://github.com/jellysquid3/sodium-fabric/pull/250

@LambdAurora
Copy link
Owner

If it's based off the dev branches it should work, but unsure.

I prefer to wait for the big refactor before looking at it.

But the mixin should not be broken in theory.

@ghost
Copy link
Author

ghost commented Aug 19, 2020

I just tested with the unoffical 1.16.2 dev build (after compiling it) and LambDynamicLights work.

I used this fork: https://github.com/FlashyReese/sodium-fabric

@LambdAurora LambdAurora added bug Something isn't working fixed The issue is fixed, if not closed then waiting for confirmation. labels Sep 7, 2020
@LambdAurora LambdAurora added the sodium The issue is related to Sodium. label Sep 29, 2020
@ghost ghost closed this as completed Oct 25, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed The issue is fixed, if not closed then waiting for confirmation. sodium The issue is related to Sodium.
Projects
None yet
Development

No branches or pull requests

1 participant