Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content/custom errors #95

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Content/custom errors #95

merged 3 commits into from
Nov 21, 2023

Conversation

mcoulthurst
Copy link

Create a static 404 page and use Metalsmith to place it in the correct location for the http-server on Heroku.
Note that this page will need to be manually copied (from errors/404.html) when the navigation changes.

@mcoulthurst mcoulthurst requested a review from a team as a code owner November 21, 2023 07:57
AndyPorter
AndyPorter approved these changes Nov 21, 2023
View reviewed changes
Copy link

@AndyPorter AndyPorter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to trust this will work, or we best test if it works in staging/production. If not we can roll back.

@AndyPorter AndyPorter merged commit e877b45 into main Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanidavies romanidavies romanidavies approved these changes

@AndyPorter AndyPorter AndyPorter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcoulthurst @AndyPorter @romanidavies