Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Nyzul Boss Item Drop Errors #6552

Closed
3 tasks done
UmeboshiXI opened this issue Dec 18, 2024 · 1 comment · Fixed by #6555
Closed
3 tasks done

🐛 Nyzul Boss Item Drop Errors #6552

UmeboshiXI opened this issue Dec 18, 2024 · 1 comment · Fixed by #6555
Labels
bug Something isn't working

Comments

@UmeboshiXI
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

#6490
Kill boss NMs on boss floors, see nothing drops and you get an error in your map log.

Expected behavior

Boss mobs should drop equipment on the corresponding floors. See "Rewards" section here

Right now, these drops are controlled through the nyzul_boss_drops mixin in /server/scripts/mixins/ and the error is a result of a drop ID being out of range/not existing in mob_droplist.sql.

@UmeboshiXI UmeboshiXI added the bug Something isn't working label Dec 18, 2024
@UmeboshiXI
Copy link
Contributor Author

UmeboshiXI commented Dec 18, 2024

An example from my server. Will need to be audited for following:

  • Drop ID will need to be adjusted to fit the next entry in mob_droplist.sql for LSB.
  • Drop groupings (I don't know if they are grouped or independent drops on retail)
  • Drop rates

Edit: You would then plug in these new DropIDs into the nyzul_boss_drops mixin mentioned above.

-- Nyzul Isle Boss Drops (Floor 20)
INSERT INTO `mob_droplist` VALUES (4020,1,1,1000,15734,@COMMON);  -- Denali Gamashes
INSERT INTO `mob_droplist` VALUES (4020,1,1,1000,15733,@COMMON);  -- Askar Gambieras
INSERT INTO `mob_droplist` VALUES (4020,1,1,1000,15735,@COMMON);  -- Goliard Clogs

-- Nyzul Isle Boss Drops (Floor 40)
INSERT INTO `mob_droplist` VALUES (4021,1,1,1000,15648,@COMMON);  -- Denali Kecks
INSERT INTO `mob_droplist` VALUES (4021,1,1,1000,15647,@COMMON);  -- Askar Dirs
INSERT INTO `mob_droplist` VALUES (4021,1,1,1000,15649,@COMMON);  -- Goliard Trews

-- Nyzul Isle Boss Drops (Floor 60)
INSERT INTO `mob_droplist` VALUES (4022,1,1,1000,14984,@COMMON);  -- Denali Wristbands
INSERT INTO `mob_droplist` VALUES (4022,1,1,1000,14983,@COMMON);  -- Askar Manopolas
INSERT INTO `mob_droplist` VALUES (4022,1,1,1000,14985,@COMMON);  -- Goliard Cuffs

-- Nyzul Isle Boss Drops (Floor 80)
INSERT INTO `mob_droplist` VALUES (4023,1,1,1000,14569,@COMMON);  -- Denali Jacket
INSERT INTO `mob_droplist` VALUES (4023,1,1,1000,14568,@COMMON);  -- Askar Korazin
INSERT INTO `mob_droplist` VALUES (4023,1,1,1000,14570,@COMMON);  -- Goliard Saio

-- Nyzul Isle Boss Drops (Floor 100)
INSERT INTO `mob_droplist` VALUES (4024,1,1,1000,16107,@COMMON);  -- Denali Bonnet
INSERT INTO `mob_droplist` VALUES (4024,1,1,1000,16106,@COMMON);  -- Askar Zucchetto
INSERT INTO `mob_droplist` VALUES (4024,1,1,1000,16108,@COMMON);  -- Goliard Chapeau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant