Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API call can trigger unwanted behaviour on non-Mastodon sites #29

Closed
plttn opened this issue Dec 21, 2022 · 3 comments
Closed

API call can trigger unwanted behaviour on non-Mastodon sites #29

plttn opened this issue Dec 21, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@plttn
Copy link

plttn commented Dec 21, 2022

Hey there! I've been running into this, and wasn't sure what caused it until just now, but with FediAct installed and enabled, anytime I browse to https://macrumors.com, I end up with an HTTP basic auth prompt appearing. This happens on both Firefox and Chrome. Interestingly enough, I don't see any requests in the extension network log that would be triggering this.

@Lartsch
Copy link
Owner

Lartsch commented Dec 21, 2022

Hi there!

Just gave it a look. Seems like the API call that FediAct needs to make to determine if the site is a Mastodon instance triggers this.

macrumors.com possibly triggers the basic auth for all URLs starting with /api/...

I'll think about how to prevent this, thanks for the heads up

@Lartsch Lartsch changed the title Fediact results in HTTP basic auth prompt on Macrumors API call can trigger unwanted behaviour on non-Mastodon sites Dec 21, 2022
@Lartsch Lartsch added the bug Something isn't working label Dec 21, 2022
@Lartsch
Copy link
Owner

Lartsch commented Dec 21, 2022

The only way I can think of to fix this is to drop the API call to /api/v1/instance and determine if it's a Mastodon site by checking for DOM elements instead.

@Lartsch
Copy link
Owner

Lartsch commented Dec 21, 2022

Fixed in 0.9.8.4 (not by switching to DOM elements, but by performing the request in the background script)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants