Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow objects of libember::glow::GlowRootElementCollection to be automatic #13

Closed
GoogleCodeExporter opened this issue Jul 31, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

At the moment the library forces to use 
libember::glow::GlowRootElementCollection::create() in to create an object of 
this type (and as consequence, a delete is required). Most often, this is not 
required because this object is only used to create a message, serialize it and 
throw it away.

I propose to stop forcing this.

Original issue reported on code.google.com by nullable...@gmail.com on 20 Jun 2013 at 8:34

@GoogleCodeExporter
Copy link
Author

My solution would be to just make the default constructor public and set the 
tag to GlowTags::Root().
Does anybody have other suggestions for this?

Original comment by p...@l-s-b.de on 27 Jun 2013 at 3:02

  • Changed state: Accepted
  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

@Philip:

I added a patch to solve this issue. Please review the changes and let me know 
if the changes are ok for you.

I marked libember::glow::GlowRootElementCollection::create() as deprecated 
(doxygen command) - i would remove it after the next release.

Original comment by nullable...@gmail.com on 4 Nov 2013 at 7:46

Attachments:

@GoogleCodeExporter
Copy link
Author

This issue was closed by revision r76.

Original comment by nullable...@gmail.com on 5 Nov 2013 at 7:13

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

@ Philip:

I applied the patch, please review and change or revert it, if not suitable.

Original comment by nullable...@gmail.com on 5 Nov 2013 at 7:14

@GoogleCodeExporter
Copy link
Author

Cool - thanks, Simon!

Original comment by p...@l-s-b.de on 5 Nov 2013 at 8:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant