Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade QGIS #909

Open
jirik opened this issue Aug 30, 2023 · 4 comments
Open

Upgrade QGIS #909

jirik opened this issue Aug 30, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@jirik
Copy link
Member

jirik commented Aug 30, 2023

No description provided.

@jirik jirik added the enhancement New feature or request label Aug 30, 2023
@jirik jirik added this to the Future release milestone Aug 30, 2023
@jirik
Copy link
Member Author

jirik commented Aug 30, 2023

Trying version 3.32.2 (currently Layman uses 3.16)

  • tested src/layman/layer/qgis, just small pixel differences in thumbnails
  • tested tests/dynamic_data/publication_test.py::test_action_chain[dynamic_test_workspace_crs_vectors*

So it seems QGIS 3.32.2 understands styles v3.16.

@jirik
Copy link
Member Author

jirik commented Sep 13, 2023

Known failing tests with 3.32.2:

  • tests/static_data/single_publication/layers_test.py::test_fill_project_template[test_workspace-layman.layer-post_strange_attributes_qml] FAILED
    
        wmsi = WebMapService(wms_url, version=wms_version)
        assert publication in wmsi.contents
        wms_layer = wmsi.contents[publication]
        exp_output_srs = set(settings.LAYMAN_OUTPUT_SRS_LIST)
        assert exp_output_srs.issubset(set(wms_layer.crsOptions))
        wms_layer_bbox = next((tuple(bbox_crs[:4]) for bbox_crs in wms_layer.crs_list if bbox_crs[4] == layer_crs))
>       assert_util.assert_same_bboxes(wms_layer_bbox, layer_bbox, 0.1)

tests/static_data/single_publication/layers_test.py:248: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

bbox1 = (-180.0, -90.0, 180.0, 90.0), bbox2 = (18.913842, 48.46164, 18.913842, 48.46164), precision = 0.1

    def assert_same_bboxes(bbox1, bbox2, precision):
        assert len(bbox1) == 4, (bbox1, len(bbox1))
        assert len(bbox2) == 4, (bbox2, len(bbox2))
        for i in range(0, 3):
>           assert abs(bbox2[i] - bbox1[i]) <= precision, (bbox1, bbox2, precision, i)
E           AssertionError: ((-180.0, -90.0, 180.0, 90.0), (18.913842, 48.46164, 18.913842, 48.46164), 0.1, 0)
E           assert 198.913842 <= 0.1
E            +  where 198.913842 = abs((18.913842 - -180.0))

test_tools/assert_util.py:34: AssertionError

@index-git
Copy link
Collaborator

index-git commented Jan 23, 2024

small_layer_334.zip
Sample style small_layer.qml loaded and saved with QGIS desktop 3.34.3-Prizren
ne_10m_admin_0_countries_qgis334.zip
Sample style ne_10m_admin_0_countries.qml loaded and saved with QGIS desktop 3.34.3-Prizren

@index-git
Copy link
Collaborator

Styles loaded and saved with QGIS desktop 3.40.1-Bratislava:
ne_10m_admin_0_countries_qgis340.zip
small_layer_340.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants