Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle WMS requests with HTTP error more efficiently in timgen #960

Closed
jirik opened this issue Nov 22, 2023 · 0 comments
Closed

Handle WMS requests with HTTP error more efficiently in timgen #960

jirik opened this issue Nov 22, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone
Release v1.23

Comments

@jirik
Copy link
Member

jirik commented Nov 22, 2023

Expected behavior
If WMS request in timgen returns HTTP status code 4xx or 5xx, timgen retries to send the request and if it fails, it stops immediately (by writing error message to canvas_data_url_error).

Found behavior
If WMS request in timgen returns HTTP status code 4xx or 5xx, timgen does not retry the request and it does not write error message to canvas_data_url_error. Therefore thumbnail.py waits for all tries and this waiting is unwanted.
@jirik jirik added the enhancement New feature or request label Nov 22, 2023
@jirik jirik added this to the Release v1.23 milestone Nov 22, 2023
@jirik jirik changed the title Timgen timeouts in case of WMS HTTP error Handle WMS requests with HTTP error more efficiently in timgen Nov 22, 2023
@jirik jirik mentioned this issue Nov 22, 2023
Merged
3 tasks
@jirik jirik closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release v1.23
Development

No branches or pull requests
1 participant
@jirik