Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance of string + string in func DecompressFromBase64 is too bad, and strings.Builder{} or bytes.Buffer{} is better. #5

Closed
llj1990 opened this issue Apr 14, 2021 · 3 comments
Closed

Performance of string + string in func DecompressFromBase64 is too bad, and strings.Builder{} or bytes.Buffer{} is better. #5

llj1990 opened this issue Apr 14, 2021 · 3 comments

Comments

@llj1990
Copy link

llj1990 commented Apr 14, 2021

No description provided.

@little-gg-bound
Copy link

i think here are some big problems with performance,it will cause performance problems when using long strings
image
image

@little-gg-bound little-gg-bound mentioned this issue Apr 15, 2021
Closed
@lazarus lazarus closed this as completed Apr 15, 2021
@Albinzr
Copy link

Albinzr commented Apr 21, 2021

Is there a fix or was it just closed?

@lazarus
Copy link
Owner

lazarus commented Apr 21, 2021

Is there a fix or was it just closed?

Fixed in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Albinzr @llj1990 @lazarus @little-gg-bound