-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for Bliss.shy #154
Comments
When I needed to test something similar on another project, I created 2 separate Karma configs. But then I lost ability to run Karma tests in continuous mode. So I didn't like that solution. Then of course Require.js can be used with Karma too. I feel this is a somewhat related feature opened on Karma that covers many use cases like grouping test files. Unfortunately it looks like it wouldn't be implemented, because spec is non trivial for this feature (so meta):
There is discussion Should we make Bliss a dependency? for Awesomplete. I hope one day (ES6) modules would be used in Bliss source. Would be easier to do many things. |
This is a serious problem that we do need to solve somehow. Another serious problem is testing in various browsers, to make sure that we're not depending on some kind of browser bug. No suggestions at the moment, about either of these issues :( |
The Browserstack and SauceLabs were mentioned in #82 to help with testing in various browsers. |
I guess I've been "lucky" to pick the hardest featureset to write tests for for my first contribution. This may sound obvious but I'll ask anyway. Is there a in-browser test runner that we could use with the same tests? With that, we could continue develop features and test them while other works on making it a module. |
There's Jasmine. But the syntax isn't the same :( ... but we may have something for us with karma-jasmine though. (after checks) but we have it already. |
@renoirb I'm not quite sure what do you mean by this. Karma already runs tests in Chrome. It doesn't matter whether it's mocha or Jasmine tests. Do you mean using the same set of tests for in-browser and in-node tests? But then why would Bliss need to be tested in node? The discussion in #71 about having HTML reporter to see results and re-run tests in browser is weird. Why not use console? There are some plugins to see test results in HTML though and the page can be reloaded to re-run them. Also Karma has continuous mode. When you run it with |
the tests are actually written in Mocha, #1 Jasmine in the NPM dependancies is just leftover. I can prune that, or anyone can pull request that cleanup. I think that running in the console for development is ideal, and then having integration with something like SauceLabs for testing cross browser on commit like we are currently doing with Travis would be best. To run all the browsers locally would take quite a bit of setup. I have done this before and dealing with VirtualBox for the IE browsers is less than convenient. |
Agree @dperrymorrow! |
Thanks for the clarification @dperrymorrow, I wasn't sure if it was needed or not. I was confused on how Mocha runs tests @vlazar but now I get it, it runs in browsers you connect the websocket servers to. This is new stuff for me. But it all makes sense now. |
For the cross-browser testing, I am currently testing Umbrella JS (which is really similar to Bliss) in the following way:
|
How should we test Bliss in
shy
mode?A few questions came up to mind when I started looking how we test shy mode.
document
to init onto?Expexted outcome
Test all
shy
mode features and ensure it behaves as documented.The text was updated successfully, but these errors were encountered: