-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option in Bliss.full to exclude addEventListener hijacking #173
Comments
We need to think a bit more about the name, but I like the idea. |
One problem is that it's not enough to add the option and wrap the hijacking with a conditional. The parts that assume hijacking around the code would also need to change (mainly the event-related functions, e.g. unbind). |
@LeaVerou I've diff'd bliss.shy.js and bliss.js and can't see any difference except the additional code at the end if bliss.js. In other words I can't see any code in |
Yes, because those parts in Bliss Shy are there regardless, and check if the |
@LeaVerou Ok I understand now. For my use case I can avoid using That said I can't see that |
I'm stuck with using jQuery and would still like to use the _ property on elements and arrays, However if I use Bliss Full I'm running into various issues with addEventListener etc. hijacking.
One way to resolve this is to add a new option:
Bliss.NoHijack
and wrapif ( !Bliss.NoHijack ){...}
around the addEventListener and removeEventListener hijack code. And use<script>self.Bliss = { NoHijack: true };</script>
in the html file before bliss loads.The text was updated successfully, but these errors were encountered: