Geosearch #1560
Merged
Geosearch #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests passing and geoSearch works. Still need to cast the return documents back into their models
also, updated the tests. everything now casts appropriately.
| callback = options; | ||
| options = {}; | ||
| } | ||
| if (!callback || 'function' != typeof callback) { |
There was a problem hiding this comment.
we could drop the !callback since the other check covers it.
| var temp = res.results[i]; | ||
| res.results[i] = new self(); | ||
| res.results[i].init(temp, {}, function (err) { | ||
| if (err) return callback(err); |
There was a problem hiding this comment.
we should guard against potentially calling the callback multiple times.
… times, now passing errors more node-like
making sure that errors sent back to the user are `instanceof Error`
updated the tests to reflect the new way the errors are passed to the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial geoSearch support for Mongoose. Should work pretty similar to the way mapreduce does.