Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context label to counter (LL-266 & LLC-16) #1508

Merged
merged 22 commits into from
May 13, 2020
Merged

Add context label to counter (LL-266 & LLC-16) #1508

merged 22 commits into from
May 13, 2020

Conversation

vladislav-999
Copy link
Contributor

@vladislav-999 vladislav-999 commented Jan 21, 2020

Copy link
Contributor

@lydiamross lydiamross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it needs to be on all counter visualisations (not just the templates), so can you add it to the custom counter as well please.

Copy link
Contributor

@lydiamross lydiamross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding to the custom counter 👍
Just one more thing

lib/models/visualisation.js Outdated Show resolved Hide resolved
ui/src/components/Counter/index.js Outdated Show resolved Hide resolved
ui/src/components/Counter/index.js Outdated Show resolved Hide resolved
ui/src/components/Counter/index.js Outdated Show resolved Hide resolved
ui/src/components/Counter/styles.css Outdated Show resolved Hide resolved
ui/src/containers/Visualisations/CustomCounter/Editor.js Outdated Show resolved Hide resolved
ui/src/containers/Visualisations/components/CommentForm.js Outdated Show resolved Hide resolved
@crazy-grizzly crazy-grizzly changed the title Ll 266 Add context label to counter Add context label to counter[LL-266] Feb 6, 2020
Comment on lines 98 to 99
console.log('hasContextLabel');
console.log(hasContextLabel);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these can be removed

@ryasmi ryasmi changed the title Add context label to counter[LL-266] Add context label to counter (LL-266 & LLC-16) Mar 16, 2020
@ryasmi ryasmi merged commit c3283fe into master May 13, 2020
@ryasmi ryasmi deleted the LL-266 branch May 13, 2020 09:25
@HT2Bot
Copy link
Member

HT2Bot commented May 13, 2020

🎉 This PR is included in version 6.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants