Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Google Login): Prevents uninvited users gaining access (LLC-10) #1517

Merged
merged 9 commits into from
Mar 20, 2020
Merged

fix(Google Login): Prevents uninvited users gaining access (LLC-10) #1517

merged 9 commits into from
Mar 20, 2020

Conversation

crazy-grizzly
Copy link
Contributor

@crazy-grizzly crazy-grizzly commented Feb 11, 2020 •
edited by ryasmi
Loading

@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2020

This pull request introduces 1 alert when merging 7cc5a53 into 2dd3ab6 - view on LGTM.com

new alerts:

  • 1 for Missing rate limiting

@crazy-grizzly crazy-grizzly requested a review from ryasmi February 12, 2020 09:27
ryasmi
ryasmi reviewed Feb 12, 2020
View reviewed changes
Copy link
Member

@ryasmi ryasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments to remove console logs.

ui/src/utils/oauth.js Outdated Show resolved Hide resolved
ui/src/utils/oauth.js Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2020

This pull request introduces 1 alert when merging 439bc26 into 2dd3ab6 - view on LGTM.com

new alerts:

  • 1 for Missing rate limiting

@ryasmi ryasmi changed the title On Google Auth, do not allow user in if they do not already exist [LL-295] fix(Google Login): Do not allow user to login if they do not already exist. (LL-295) Feb 14, 2020
@lgtm-com
Copy link

lgtm-com bot commented Feb 20, 2020

This pull request introduces 1 alert when merging 14337d2 into 9b59592 - view on LGTM.com

new alerts:

  • 1 for Missing rate limiting

@lgtm-com
Copy link

lgtm-com bot commented Mar 13, 2020

This pull request introduces 1 alert when merging 53e7a57 into d34bafa - view on LGTM.com

new alerts:

  • 1 for Missing rate limiting

@lgtm-com
Copy link

lgtm-com bot commented Mar 13, 2020

This pull request introduces 1 alert when merging 13258be into d34bafa - view on LGTM.com

new alerts:

  • 1 for Missing rate limiting

@lgtm-com
Copy link

lgtm-com bot commented Mar 13, 2020

This pull request introduces 1 alert when merging bf46b19 into d34bafa - view on LGTM.com

new alerts:

  • 1 for Missing rate limiting

@ryasmi ryasmi changed the title fix(Google Login): Do not allow user to login if they do not already exist. (LL-295) fix(Google Login): Do not allow user to login if they do not already exist. (LL-295 & LLC-10) Mar 20, 2020
@ryasmi ryasmi changed the title fix(Google Login): Do not allow user to login if they do not already exist. (LL-295 & LLC-10) fix(Google Login): Prevents uninvited users gaining access (LLC-10) Mar 20, 2020
@lgtm-com
Copy link

lgtm-com bot commented Mar 20, 2020

This pull request introduces 1 alert when merging 651e3bf into 334935f - view on LGTM.com

new alerts:

  • 1 for Missing rate limiting

@ryasmi ryasmi merged commit 8d0e78b into master Mar 20, 2020
@ryasmi ryasmi deleted the LL-295 branch March 20, 2020 12:05
@HT2Bot
Copy link
Member

HT2Bot commented Mar 20, 2020

🎉 This PR is included in version 6.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryasmi ryasmi ryasmi approved these changes

Assignees
No one assigned
Labels
released Type: Fix Type: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crazy-grizzly @HT2Bot @ryasmi