Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring changes in https://github.com/shareef-dweikat/flutter-intro-slider upstream #208

Open
wuan opened this issue Dec 13, 2022 · 5 comments
Labels
Tech Debt Technical debt, small improvements to code, libraries

Comments

@wuan
Copy link
Contributor

wuan commented Dec 13, 2022

We have forked that repo during the development and should have a look on how to bring those changes upstream.

@donpui
Copy link
Contributor

donpui commented Dec 14, 2022

@shareef-dweikat maybe you can comment on changes it self. To my understanding, we modified flutter-intro-slider to make our own intro pages with our styles, buttons and names

@donpui
Copy link
Contributor

donpui commented Dec 14, 2022

Additionally we should think, that maybe all these forks should be consolidated under LeastAuthority organisation

@donpui
Copy link
Contributor

donpui commented Dec 14, 2022

One more, we need also to downstream before upstreaming anything, because we already cannot update some plugins, because of this plugin dependencies to older packages.

@wuan
Copy link
Contributor Author

wuan commented Dec 14, 2022

Additionally we should think, that maybe all these forks should be consolidated under LeastAuthority organisation

I would first like to investigate to upstream all the features we added to reduce maintenance on our side.

@donpui
Copy link
Contributor

donpui commented Dec 14, 2022

@donpui donpui added the Tech Debt Technical debt, small improvements to code, libraries label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tech Debt Technical debt, small improvements to code, libraries
Projects
None yet
Development

No branches or pull requests

2 participants