Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Decouple interactions between SimpleFOC and MicroROS #31

Open
Legohead259 opened this issue Dec 24, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Legohead259
Copy link
Owner

Is your feature request related to a problem? Please describe.
The MicroROS implementation has a strong dependency on the SimpleFOC implementation right now, requiring the use of the motor and sensorFOC objects.

Describe the solution you'd like
This dependency should be removed by passing SimpleFOC functions like motor.disable(), motor.enable(), and sensorFOC.getAngle() as callbacks to the SimpleFOC functions. Micro-ROS does not need to interact directly with these sensors, rather just know to make these callbacks when necessary. The callbacks can be set in the main script initialization function.

This may also reduce the risk of circular dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant