Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor defect: missing invalidation or PResult #11

Open
Reissner opened this issue May 15, 2020 · 0 comments
Open

minor defect: missing invalidation or PResult #11

Reissner opened this issue May 15, 2020 · 0 comments

Comments

@Reissner
Copy link

To have consistent results, PResult must be invalidated when loading/saving.
In fact, there is no invalidation when saving at all and also there is no invalidation,
when loading from file and the stream cannot be opened.
As a consequence, even if saving succeeds, there may be an error code from previous operation.
Also if loading fails because the stream cannot be opened,
then all information in PResult are irrelevant but error_code. Shall be 0 thus.

By the way, maybe the name PResult is historical: "ParseResult"?
Maybe better: read/write result RWResult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant