Fix change that broke notify/reload, update nginx handler #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update handler to use ansible.builtin.systemd module
codyro
requested review from
Nutomic,
dessalines and
ticoombs
as code owners
- Use `loop` instead of `with_items` - Use a handler & systemd module to handle nginx reloads - Refs #166 changes suggested by @sanatsathaye
dessalines
approved these changes
Sep 12, 2023
snowe2010
pushed a commit
to programming-dot-dev/lemmy-ansible
that referenced
this pull request
Jan 30, 2024
* Fix change that broke notify/reload - Update handler to use ansible.builtin.systemd module * Clean up `lemmy.yml` a bit more - Use `loop` instead of `with_items` - Use a handler & systemd module to handle nginx reloads - Refs LemmyNet#166 changes suggested by @sanatsathaye * Move `notify` key higher to satiate `ansible-lint`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lemmy-almalinux.ymlto use ansible.builtin.systemd modulenginxreloading inlemmy.ymlI will make similar changes to the primary playbook later, but since this is breaking, I want to merge it ASAP. This is another good use case for getting proper testing (e.g., Molecule). The only hindrance I've had in that realm is requiring Docker In Docker to fully test the playbooks.