Make firewalld operations idempotent

[sanatsathaye]

I haven't worked much with ansible.posix.firewalld before, so let me know if there's something which needs changing. Think I've translated it over correctly though.

[codyro]

We should add a requirements.yml file with the ansible.posix collection as well.

---
collections:
  - name: ansible.posix

[sanatsathaye]

Sorry for the delay I've been very busy IRL with work and exams, I'll resume working on this some time next week

[codyro]

No rush! Thank you for your time on improving these playbooks and the Lemmy ecosystem as a whole!

[sanatsathaye]

No problem, need a good reddit alternative 😄
Btw I suppose I'll have to put instructions to run requirements.yml in the readme somewhere?

[codyro]

I suppose I'll have to put instructions to run requirements.yml in the readme somewhere?

If you don't mind, that'd be fantastic. While doing that, could you add that these playbooks require Ansible >= 2.10? We ran into an issue with notify not being supported in blocks in older versions (#177).

Thank you!

[sanatsathaye]

While doing that, could you add that these playbooks require Ansible >= 2.10? We ran into an issue with notify not being supported in blocks in older versions (#177).

I believe it's possible to use ansible itself to check which version is running the playbook using {{ ansible_version }} -- I can do another PR to add that into lemmy.yml and lemmy-almalinux.yml, and add the requirement in the readme as well if that's alright. Don't think it should be needed for the uninstall playbook.

Btw, should we be tying down the collections in the requirements.yml to any specific version number? Just realised I'll need to add community.docker as well as that's part of the Ubuntu install playbook, so I can point that as well as ansible.posix to the current latest version of both if that is required. If not, then I'll just add as is.